Will Berkeley has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column ......................................................................
Patch Set 6: (2 comments) Two doc+comment fixes and LGTM. I think the test failures are unrelated timeouts. http://gerrit.cloudera.org:8080/#/c/6078/6/docs/known_issues.adoc File docs/known_issues.adoc: PS6, Line 37: (col1 to col2 I don't think this helps. If you remove it, I think it will be fine, as it says first that keys can be renamed before saying they can't be changed. http://gerrit.cloudera.org:8080/#/c/6078/6/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS6, Line 3224: test that renames primary key column name nit: test renaming primary key column -- To view, visit http://gerrit.cloudera.org:8080/6078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ram Mettu <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ram Mettu <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
