Ram Mettu has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column ......................................................................
Patch Set 4: (4 comments) Added test cases from alter_table-test.cc and alter_table-randomized-test.cc as suggested. http://gerrit.cloudera.org:8080/#/c/6078/3//COMMIT_MSG Commit Message: PS3, Line 9: renaming of primary key : columns, adde > nit: renaming of primary key columns Done http://gerrit.cloudera.org:8080/#/c/6078/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java: PS3, Line 35: > We loosely adhere to Google's Java style guide, which disallows wildcard im reverted back to the original PS3, Line 161: > Can you add a row before the alter as well? An alter should trigger a flush Done PS3, Line 171: > Can you check the results of a scan are correct? Try using a projection on Done -- To view, visit http://gerrit.cloudera.org:8080/6078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ram Mettu <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ram Mettu <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
