Todd Lipcon has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column ......................................................................
Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/6078/11/src/kudu/common/schema.h File src/kudu/common/schema.h: PS11, Line 218: bitset<8> checks = UCHAR_MAX hrm, we don't actually use std::bitset elsewhere for this style of flag, and instead use 'int' and a normal enum. Check out util/trace.h:164 for example. PS11, Line 287: static const uint8_t COMPARE_NAME = 0x01; : static const uint8_t COMPARE_TYPE = 0x02; : static const uint8_t COMPARE_DEFAULTS = 0x04; please switch to enum following the example in trace.h -- To view, visit http://gerrit.cloudera.org:8080/6078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ram Mettu <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ram Mettu <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
