Ram Mettu has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column ......................................................................
Patch Set 8: (5 comments) Addressed Todd's comments http://gerrit.cloudera.org:8080/#/c/6078/7/docs/known_issues.adoc File docs/known_issues.adoc: PS7, Line 36: * The primary key may not be changed after the table is cr > I don't think we need this sentence at all given this is a "limitations" se Done http://gerrit.cloudera.org:8080/#/c/6078/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java: Line 162: // scanning with the old schema > can you add some assertion of what happens if you try scanning with the old Done http://gerrit.cloudera.org:8080/#/c/6078/7/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS7, Line 3233: that changing the data type of a primar > nit: "Test that changing the data type of a primary key column throws an er Done PS7, Line 3240: Not implemented: cannot alter attributes for column: key2"); > this isn't a great error message. Can we improve it to be more clear, like Changed the error msg a little but not specific as suggested, the code throwing this error does a lot of checks (eg primary key, compression, encoding etc), hope that is okay http://gerrit.cloudera.org:8080/#/c/6078/7/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: PS7, Line 947: : > I think we should still have some dcheck that the IDs and types match, even Done -- To view, visit http://gerrit.cloudera.org:8080/6078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ram Mettu <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ram Mettu <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
