Todd Lipcon has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column ......................................................................
Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/6078/7/docs/known_issues.adoc File docs/known_issues.adoc: PS7, Line 36: * Columns that are part of the primary key can be renamed. I don't think we need this sentence at all given this is a "limitations" section. http://gerrit.cloudera.org:8080/#/c/6078/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java: Line 162: // Reopen table for the new schema. can you add some assertion of what happens if you try scanning with the old schema? make sure the exception is reasonable? http://gerrit.cloudera.org:8080/#/c/6078/7/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS7, Line 3233: that changes dataType of primary column nit: "Test that changing the data type of a primary key column throws an error" PS7, Line 3240: Not implemented: cannot support AlterColumn of this type: key2 this isn't a great error message. Can we improve it to be more clear, like "cannot alter columns that are part of the primary key"? http://gerrit.cloudera.org:8080/#/c/6078/7/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 927 see below PS7, Line 947: : I think we should still have some dcheck that the IDs and types match, even if the names may have changed. -- To view, visit http://gerrit.cloudera.org:8080/6078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ram Mettu <ram.me...@rms.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ram Mettu <ram.me...@rms.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
