Will Berkeley has posted comments on this change. Change subject: [WIP] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6772/1/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: Line 69: const std::string& tablet_id, > warning: parameter 'tablet_id' is unused [misc-unused-parameters] Expected. Line 70: const Schema& schema, > warning: parameter 'schema' is unused [misc-unused-parameters] Expected. http://gerrit.cloudera.org:8080/#/c/6772/1/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: Line 630: for (const shared_ptr<KsckTabletReplica> replica : tablet->replicas()) { > warning: the loop variable's type is not a reference type; this creates a c Done Line 659: if (consensus_pb.has_leader_uuid() && consensus_pb.leader_uuid().size() > 0) { > warning: the 'empty' method should be used to check for emptiness instead o Done http://gerrit.cloudera.org:8080/#/c/6772/1/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: Line 99: leader_uuid_(leader_uuid), > warning: value argument 'leader_uuid' can be moved to avoid copy [misc-move Done -- To view, visit http://gerrit.cloudera.org:8080/6772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e4de09821b372c3773b4ade3fd9e37ab818808 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
