Mike Percy has posted comments on this change. Change subject: [WIP] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6772/4/src/kudu/consensus/consensus.proto File src/kudu/consensus/consensus.proto: PS4, Line 471: optional why not required? Line 474: repeated bytes tablet_ids = 2; Maybe we should specify that if this is empty then it means fetch consensus info for all of the tablets Line 480: optional ConsensusStatePB cstate = 2; how about: message GetAllConsensusStatesResponsePB { message TabletConsensusInfoPB { required bytes tablet_id = 1; optional int64 current_term = 2; optional bytes leader_uuid = 3; optional RaftConfigPB committed_config = 4; optional RaftConfigPB pending_config = 5; } repeated TabletConsensusInfoPB tablets = 1; optional tserver.TabletServerErrorPB error = 2; } And then only fill in pending_config if there is a config change pending. http://gerrit.cloudera.org:8080/#/c/6772/4/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: PS4, Line 1074: CONSENSUS_CONFIG_ACTIVE We may want to plumb in a way to get both the committed and pending consensus states at the same time. -- To view, visit http://gerrit.cloudera.org:8080/6772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e4de09821b372c3773b4ade3fd9e37ab818808 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
