Mike Percy has posted comments on this change. Change subject: [WIP] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config ......................................................................
Patch Set 4: > I implemented a GetAllConsensusStates RPC and used it instead of > one GetConsensusState RPC per tablet replica I think it would be better to fully replace it with the new RPC because if you do a search it's not used anywhere except tests. > However, this makes the new features available only for > servers >= 1.4. Should we stick both forms of logic in > so it works on older servers? I don't think it's important for it to work on older servers since it's a new command. -- To view, visit http://gerrit.cloudera.org:8080/6772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e4de09821b372c3773b4ade3fd9e37ab818808 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: No
