Mike Percy has posted comments on this change. Change subject: [WIP] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6772/1/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: Line 716: } else if (consensus_conflict) { > Yes, that's part of a core problem with these consensus checks: we can't re I think it would be useful to include stats about how long the config has been pending if there is a pending config. It shouldn't be too hard to add. However I agree that using comparisons to decide whether there is a problem is hard to get right. Another thing to consider for a tablet health check would be adding a no-op canary. I agree allowing all info to be printed wouldn't necessarily be a bad thing, even if we don't flag it as an error but potentially as a warning. http://gerrit.cloudera.org:8080/#/c/6772/1/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: PS1, Line 124: int64_t term_; : boost::optional<string> leader_uuid_; : vector<string> peers_; > If you make them const it breaks the assignment at ksck.cc L663 since the c k -- To view, visit http://gerrit.cloudera.org:8080/6772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e4de09821b372c3773b4ade3fd9e37ab818808 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
