David Ribeiro Alves has posted comments on this change. Change subject: util: add fault injection of EIOs ......................................................................
Patch Set 14: (4 comments) http://gerrit.cloudera.org:8080/#/c/6881/14/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: PS14, Line 939: scoped_refptr<MetricEntity>(), : shared_ptr<MemTracker>(), : { GetTestDataDirectory() }, : false /* create */)); nit: indent http://gerrit.cloudera.org:8080/#/c/6881/14/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: PS14, Line 984: TestEIOTrigger nit: howbout TestInjectEIO PS14, Line 1020: s = rw1->Size(&size); could you alternate some other IO operations? specifically writes, reads and fsyncs? also could you test a dir glob? http://gerrit.cloudera.org:8080/#/c/6881/14/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: PS14, Line 156: If empty, all files may cause a failure. so "" and "*" mean the same thing? maybe just make the default "*" to make it explicit and just mention that? -- To view, visit http://gerrit.cloudera.org:8080/6881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5190d5e7f296cf27b65f1ecd2c16f3315cc46a39 Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
