Adar Dembo has posted comments on this change. Change subject: util: add fault injection of EIOs ......................................................................
Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/6881/14/src/kudu/util/fault_injection.h File src/kudu/util/fault_injection.h: Line 85: inline Status MaybeReturnFailure(double fraction, > This is still used in server_negotiation.cc:704 and it seems it wouldn't be It's true that it can't work with the MAYBE_RETURN_FAILURE, but I think you can use MaybeTrue(): if (MaybeTrue(FLAGS_rpc_inject_invalid_authn_token_ratio)) { Status s = Status::NotAuthorized(VerificationResultToString(res))); RETURN_NOT_OK(SendError(ErrorStatusPB::FATAL_INVALID_AUTHENTICATION_TOKEN, s)); return s; } -- To view, visit http://gerrit.cloudera.org:8080/6881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5190d5e7f296cf27b65f1ecd2c16f3315cc46a39 Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
