Adar Dembo has posted comments on this change. Change subject: util: add fault injection of EIOs ......................................................................
Patch Set 14: (3 comments) Looks much better, thanks. http://gerrit.cloudera.org:8080/#/c/6881/14/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 106: #define MAYBE_RETURN_EIO(filename_expr, error_expr) do { \ IIUC, error_expr is not evaluated unless FLAGS_env_inject_eio >= 0 and the rng chooses a sufficiently high random number, right? http://gerrit.cloudera.org:8080/#/c/6881/14/src/kudu/util/fault_injection.h File src/kudu/util/fault_injection.h: PS14, Line 49: Status s_ = (status_expr); \ : RETURN_NOT_OK(s_); Can these two lines be combined? Line 85: inline Status MaybeReturnFailure(double fraction, This (and DoMaybeReturnFailure) are no longer needed, right? -- To view, visit http://gerrit.cloudera.org:8080/6881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5190d5e7f296cf27b65f1ecd2c16f3315cc46a39 Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
