Adar Dembo has posted comments on this change. Change subject: disk failure: coordinate error handling ......................................................................
Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/7029/16/src/kudu/tserver/tablet_server.cc File src/kudu/tserver/tablet_server.cc: Line 109: fs_manager_->SetErrorNotificationCb(Bind(&TSTabletManager::FailTabletsInDataDir, Why not do this in TSTabletManager::Init (and unset it in TSTabletManager::Shutdown)? Then FailTabletsInDataDir() could be private. http://gerrit.cloudera.org:8080/#/c/7029/16/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 1067: uint16_t* uuid_idx = fs_manager_->dd_manager()->GetUuidIdxForUuid(uuid); Maybe pull out fs_manager_->dd_manager() into a local variable so you don't have to repeat it? -- To view, visit http://gerrit.cloudera.org:8080/7029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3169deada702c527b70fabf9d2223364f9a9ea6 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
