Adar Dembo has posted comments on this change. Change subject: disk failure: coordinate error handling ......................................................................
Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/7029/16/src/kudu/tserver/tablet_server.cc File src/kudu/tserver/tablet_server.cc: Line 109: fs_manager_->SetErrorNotificationCb(Bind(&TSTabletManager::FailTabletsInDataDir, > The idea here is to keep all the "wiring" at as high a level as possible. T I can't speak for Todd, but I think his beef was primarily with the ctor/dtor aspect of the wiring. Init/Shutdown within TSTabletManager seems like it respects that, and it has the added bonus that the dependency affects two modules (FsManager and TSTabletManager) rather than three (FsManager, TSTabletManager, and TabletServer). Your second point is valid, though if that happens we can always refactor. -- To view, visit http://gerrit.cloudera.org:8080/7029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3169deada702c527b70fabf9d2223364f9a9ea6 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
