Andrew Wong has posted comments on this change. Change subject: disk failure: coordinate error handling ......................................................................
Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/7029/16/src/kudu/tserver/tablet_server.cc File src/kudu/tserver/tablet_server.cc: Line 109: fs_manager_->SetErrorNotificationCb(Bind(&TSTabletManager::FailTabletsInDataDir, > Why not do this in TSTabletManager::Init (and unset it in TSTabletManager:: The idea here is to keep all the "wiring" at as high a level as possible. Todd pointed out that it seems a bit strange for the initialization of a TSTabletManager to have an effect on the FsManager (these were originally in the c'tor and d'tor of TSTabletManager). Another thought might be that if the error manager is ever used for other types of errors, setting these callbacks in one place may be favorable vs spreading them across multiple Init()s. -- To view, visit http://gerrit.cloudera.org:8080/7029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3169deada702c527b70fabf9d2223364f9a9ea6 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
