Adar Dembo has posted comments on this change. Change subject: disk failure: coordinate error handling ......................................................................
Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/7029/16/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 1067: uint16_t* uuid_idx = fs_manager_->dd_manager()->GetUuidIdxForUuid(uuid); > Maybe pull out fs_manager_->dd_manager() into a local variable so you don't Did you miss this? http://gerrit.cloudera.org:8080/#/c/7029/20/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS20, Line 1074: (const st Didn't think this case was possible. http://gerrit.cloudera.org:8080/#/c/7029/20/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: Line 188: I still think it'd be OK to make this private and wire/unwire in Init/Shutdown (as opposed to the ctor/dtor). Did Todd object to that specific kind of wiring? I thought the 'weirdness' he felt had to do with side effects in the ctor. -- To view, visit http://gerrit.cloudera.org:8080/7029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3169deada702c527b70fabf9d2223364f9a9ea6 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
