Sailesh Mukil has posted comments on this change. Change subject: Adjust kerberos renewal logic to avoid tickets with NULL 'renew_till' timestamp ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7770/1//COMMIT_MSG Commit Message: PS1, Line 28: refuses to read th > maybe be slightly more specific and say that the Java library refuses to re Done PS1, Line 30: ed failures. > typo Done http://gerrit.cloudera.org:8080/#/c/7770/1/src/kudu/security/init.cc File src/kudu/security/init.cc: PS1, Line 290: > am surprised to see 'difftime'. Never seen that before. Why not just cast t http://en.cppreference.com/w/c/chrono/difftime "On POSIX systems, time_t is measured in seconds, and difftime is equivalent to arithmetic subtraction, but C and C++ allow fractional units for time_t." Also, just looking at posts online generally, people discourage using '-' to subtract two time_t objects. PS1, Line 290: > according to http://web.mit.edu/kerberos/krb5-current/doc/appldev/refs/type Good catch. I added some logic to handle that case. PS1, Line 298: > we probably want a little bit of slop here just like we had with 'renew_dea Oops, you're right. I added the renew_deadline back. -- To view, visit http://gerrit.cloudera.org:8080/7770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59194af94838f680df4ce121a8dee526a876e369 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
