Sailesh Mukil has posted comments on this change. Change subject: [security] avoid tickets with NULL 'renew_till' ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7770/2//COMMIT_MSG Commit Message: PS2, Line 7: Adjust kerberos renewal logic to avoid tickets with NULL 'renew_till' timestamp > nit: could you shorten it to fit about 50 symbols, like Done http://gerrit.cloudera.org:8080/#/c/7770/2/src/kudu/security/init.cc File src/kudu/security/init.cc: PS2, Line 295: std::min(static_cast<double>(30), ticket_lifetime) > nit: consider using Done PS2, Line 295: ticket_lifetime > Maybe, then compute renew_deadline as If we just do renew_deadline = (renew_till - 30), tickets with renew lifetime less than 30s will cause the renew_deadline to have a negative value. The idea is to add some slop for tickets that have renew lifetimes > 30s. For tickets that have < 30s renew lifetimes, we just end up renewing at the time we hit the deadline. -- To view, visit http://gerrit.cloudera.org:8080/7770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59194af94838f680df4ce121a8dee526a876e369 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
