Alexey Serbin has posted comments on this change. Change subject: Adjust kerberos renewal logic to avoid tickets with NULL 'renew_till' timestamp ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7770/2//COMMIT_MSG Commit Message: PS2, Line 7: Adjust kerberos renewal logic to avoid tickets with NULL 'renew_till' timestamp nit: could you shorten it to fit about 50 symbols, like [security] avoid tickets with NULL 'renew_till' ? http://gerrit.cloudera.org:8080/#/c/7770/2/src/kudu/security/init.cc File src/kudu/security/init.cc: PS2, Line 295: ticket_lifetime > Yes, that's true, but how low of a ticket_lifetime do we want to adjust for Maybe, then compute renew_deadline as renew_deadline = renew_till - 30.0 ? PS2, Line 295: std::min(static_cast<double>(30), ticket_lifetime) nit: consider using std::min(30.0, ticket_lifetime) or std::min<double>(30, ticket_lifetime) for brevity. -- To view, visit http://gerrit.cloudera.org:8080/7770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59194af94838f680df4ce121a8dee526a876e369 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
