Alexey Serbin has posted comments on this change. Change subject: [security] avoid tickets with NULL 'renew_till' ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7770/2/src/kudu/security/init.cc File src/kudu/security/init.cc: PS2, Line 295: > If we just do renew_deadline = (renew_till - 30), tickets with renew lifet I might be missing some crucial point here, but if renew_deadline is negative, that's fine with the if (ticket_expiry < now || (now + ticket_lifetime) > renew_deadline) condition, right? So, a ticket with lifetime of less than 30 seconds would be re-acquired here instead of renewing. Would be that a problem? -- To view, visit http://gerrit.cloudera.org:8080/7770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59194af94838f680df4ce121a8dee526a876e369 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
