Todd Lipcon has posted comments on this change. Change subject: Adjust kerberos renewal logic to avoid tickets with NULL 'renew_till' timestamp ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7770/2/src/kudu/security/init.cc File src/kudu/security/init.cc: PS2, Line 295: ticket_lifetime don't you still need a little slop here in addition to ticket_lifetime? eg if your lifetime is 30s, and it's 12:00:29, and renew_till is 12:01:00, you only have 1 second left. So if the renewal takes more than a second you'll be back in the danger zone. -- To view, visit http://gerrit.cloudera.org:8080/7770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59194af94838f680df4ce121a8dee526a876e369 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
