Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/7656 )
Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/7656/8/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: http://gerrit.cloudera.org:8080/#/c/7656/8/src/kudu/fs/block_manager.h@321 PS8, Line 321: the list of IDs of : // block that can be successfully deleted. > the list of block IDs that were successfully deleted. I put it as 'can be' because at this point, the blocks may not be deleted yet. But if you think this is more accurate, I can update it based on your suggestion. http://gerrit.cloudera.org:8080/#/c/7656/8/src/kudu/fs/block_manager.h@331 PS8, Line 331: if (!s.ok() && !s.IsNotFound() && !status.ok()) { > This should be status.ok(), right? Not !status.ok()? Right, my bad... http://gerrit.cloudera.org:8080/#/c/7656/8/src/kudu/fs/block_manager.h@334 PS8, Line 334: deleted->emplace_back(block); > Seems like you could end up here if !status.ok() but e.g. s.IsIOError(). Will update. -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-Change-Number: 7656 Gerrit-PatchSet: 8 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 21 Sep 2017 04:59:46 +0000 Gerrit-HasComments: Yes
