Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7656 )
Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/7656/9/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/7656/9/src/kudu/fs/block_manager-test.cc@1109 PS9, Line 1109: forcing force http://gerrit.cloudera.org:8080/#/c/7656/9/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: http://gerrit.cloudera.org:8080/#/c/7656/9/src/kudu/fs/block_manager.h@342 PS9, Line 342: deleted_blocks_.clear(); Shouldn't we clear regardless of error? http://gerrit.cloudera.org:8080/#/c/7656/8/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: http://gerrit.cloudera.org:8080/#/c/7656/8/src/kudu/fs/block_manager.h@321 PS8, Line 321: the list of block : // IDs that were successfully deleted. > I put it as 'can be' because at this point, the blocks may not be deleted y Yeah, I think the asynchronous deletion is a bit of an implementation detail. For example, the deletion will happen staight-away in the FBM; the fact that the on-disk file may remain around until the last opener disappears is a UNIX filesystem detail. -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-Change-Number: 7656 Gerrit-PatchSet: 9 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 21 Sep 2017 23:31:00 +0000 Gerrit-HasComments: Yes
