Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8218 )
Change subject: Allow the SASL protocol service name to be configurable ...................................................................... Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/client_negotiation.h File src/kudu/rpc/client_negotiation.h: http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/client_negotiation.h@68 PS1, Line 68: const > const is unnecessary here Done http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/client_negotiation.cc@121 PS1, Line 121: sasl_proto_name > this can be std::moved() too once the parameter is not 'const' Done http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/messenger.h File src/kudu/rpc/messenger.h: http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/messenger.h@125 PS1, Line 125: const > likewise Done http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/messenger.h@267 PS1, Line 267: const std::string sasl_proto_name() const { > const std::string& Done http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/messenger.cc@271 PS1, Line 271: sasl_proto_name > std::move here once it's not a const arg Done http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/server_negotiation.h File src/kudu/rpc/server_negotiation.h: http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/server_negotiation.h@68 PS1, Line 68: const > likewise Done http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/server_negotiation.h@150 PS1, Line 150: const > likewise Done http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8218/1/src/kudu/rpc/server_negotiation.cc@280 PS1, Line 280: sasl_proto_name > wrap in std::move Done -- To view, visit http://gerrit.cloudera.org:8080/8218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e30fe4461893b67527333259579e2304b19af1e Gerrit-Change-Number: 8218 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 18:13:51 +0000 Gerrit-HasComments: Yes
