Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8218 )
Change subject: Allow the SASL protocol service name to be configurable ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/8218/3/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8218/3/src/kudu/rpc/negotiation.cc@182 PS3, Line 182: messenger->sasl_proto_name()); > sasl_proto_name() returns a 'const string&', and the ClientNegotiation ctor Ah right. Understood, misunderstood the fact that we're taking an owned string here. Thanks for the explanation. http://gerrit.cloudera.org:8080/#/c/8218/3/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8218/3/src/kudu/rpc/server_negotiation.cc@137 PS3, Line 137: std::string sasl_proto_name) > warning: pass by value and use std::move [modernize-pass-by-value] Done http://gerrit.cloudera.org:8080/#/c/8218/3/src/kudu/rpc/server_negotiation.cc@146 PS3, Line 146: sasl_proto_name_(std::move(sasl_proto_name)), > warning: parameter 'sasl_proto_name' is passed by value and only copied onc Done -- To view, visit http://gerrit.cloudera.org:8080/8218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e30fe4461893b67527333259579e2304b19af1e Gerrit-Change-Number: 8218 Gerrit-PatchSet: 4 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 20:19:00 +0000 Gerrit-HasComments: Yes
