Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8218 )
Change subject: Allow the SASL protocol service name to be configurable ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/8218/2/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8218/2/src/kudu/rpc/client_negotiation.cc@111 PS2, Line 111: std::string sasl_proto_name) > warning: the const qualified parameter 'sasl_proto_name' is copied for each Done http://gerrit.cloudera.org:8080/#/c/8218/2/src/kudu/rpc/client_negotiation.cc@121 PS2, Line 121: sasl_proto_name_(std::move(sasl_proto_name)), > warning: std::move of the const variable 'sasl_proto_name' has no effect; r Done http://gerrit.cloudera.org:8080/#/c/8218/2/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/8218/2/src/kudu/rpc/messenger.cc@270 PS2, Line 270: MessengerBuilder &MessengerBuilder::set_sasl_proto_name(std::string sasl_proto_name) { > warning: the const qualified parameter 'sasl_proto_name' is copied for each Done http://gerrit.cloudera.org:8080/#/c/8218/2/src/kudu/rpc/messenger.cc@271 PS2, Line 271: sasl_proto_name_ = std::move(sasl_proto_name); > warning: std::move of the const variable 'sasl_proto_name' has no effect; r Done http://gerrit.cloudera.org:8080/#/c/8218/2/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8218/2/src/kudu/rpc/server_negotiation.cc@137 PS2, Line 137: std::string sasl_proto_name) > warning: the const qualified parameter 'sasl_proto_name' is copied for each Done http://gerrit.cloudera.org:8080/#/c/8218/2/src/kudu/rpc/server_negotiation.cc@268 PS2, Line 268: Status ServerNegotiation::PreflightCheckGSSAPI(std::string sasl_proto_name) { > warning: the const qualified parameter 'sasl_proto_name' is copied for each Done http://gerrit.cloudera.org:8080/#/c/8218/2/src/kudu/rpc/server_negotiation.cc@281 PS2, Line 281: nullptr, nullptr, nullptr, RpcEncryption::OPTIONAL, std::move(sasl_proto_name)); > warning: std::move of the const variable 'sasl_proto_name' has no effect; r Done -- To view, visit http://gerrit.cloudera.org:8080/8218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e30fe4461893b67527333259579e2304b19af1e Gerrit-Change-Number: 8218 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 18:43:05 +0000 Gerrit-HasComments: Yes
