Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8218 )
Change subject: Allow the SASL protocol service name to be configurable ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8218/3/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8218/3/src/kudu/rpc/negotiation.cc@182 PS3, Line 182: messenger->sasl_proto_name()); > Actually, this gets me thinking. If I'm returning a reference of the sasl_p sasl_proto_name() returns a 'const string&', and the ClientNegotiation ctor takes an owned string, so there is an implicit copy happening here (which is what we want, in order to avoid exactly the issue you bring up). Generally, moving out of a const ref or const field is really just making an implicit copy. -- To view, visit http://gerrit.cloudera.org:8080/8218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e30fe4461893b67527333259579e2304b19af1e Gerrit-Change-Number: 8218 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 20:03:19 +0000 Gerrit-HasComments: Yes
