Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8218 )
Change subject: Allow the SASL protocol service name to be configurable ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8218/3/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: http://gerrit.cloudera.org:8080/#/c/8218/3/src/kudu/rpc/negotiation.cc@182 PS3, Line 182: messenger->sasl_proto_name()); Actually, this gets me thinking. If I'm returning a reference of the sasl_proto_name_ string of the Messenger class, and I'm moving it in the ClientNegotiation() constructor, wouldn't that mean Messenger::sasl_proto_name_ is no longer valid? We'd want that to be around for the ServerNegotiation part as well. Forgive my noob-ness in the move semantics if my concern is invalid. -- To view, visit http://gerrit.cloudera.org:8080/8218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e30fe4461893b67527333259579e2304b19af1e Gerrit-Change-Number: 8218 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 19:12:17 +0000 Gerrit-HasComments: Yes
