Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 )
Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/8144/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8144/4//COMMIT_MSG@10 PS4, Line 10: so that in : future they can be extended for specific implementations. > When working on this patch, honestly speaking I do not have the intention t Yeah I think it's a good idea. I recall discussing that with you and Dan in one of our meetings a few months ago. The LBM code is complicated enough as it is so anything that simplifies it by reducing the number of code paths is welcome. http://gerrit.cloudera.org:8080/#/c/8144/6/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: http://gerrit.cloudera.org:8080/#/c/8144/6/src/kudu/fs/block_manager.h@286 PS6, Line 286: virtual const std::vector<std::unique_ptr<WritableBlock>>& created_blocks() const = 0; This isn't present in BlockDeletionTransaction and, AFAICT, is only used in tests. Can it be removed? Removing this will allow LogBlockCreationTransaction to move the down_cast of WritableBlock from CommitCreatedBlocks() to AddCreatedBlock(), which will make CommitCreatedBlocks() a little simpler. And maybe it'll allow other simplifications too. -- To view, visit http://gerrit.cloudera.org:8080/8144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60c7d437061f98ad27b9aecda5fa89e909fb2ec6 Gerrit-Change-Number: 8144 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 06 Oct 2017 00:14:43 +0000 Gerrit-HasComments: Yes
