Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 )
Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/8144/6/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/8144/6/src/kudu/fs/file_block_manager.cc@856 PS6, Line 856: return std::make_shared<internal::FileBlockDeletionTransaction>(this); Why did you remove these checks? http://gerrit.cloudera.org:8080/#/c/8144/8/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/8144/8/src/kudu/fs/log_block_manager.cc@1152 PS8, Line 1152: created_blocks_.emplace_back(unique_ptr<LogWritableBlock>(lwb)); Now that created_blocks() is gone, you could store these directly into something like created_block_map, to avoid the transformation that happens in CommitCreatedBlocks(). -- To view, visit http://gerrit.cloudera.org:8080/8144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60c7d437061f98ad27b9aecda5fa89e909fb2ec6 Gerrit-Change-Number: 8144 Gerrit-PatchSet: 8 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 06 Oct 2017 22:17:37 +0000 Gerrit-HasComments: Yes
