Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 )
Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/8144/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8144/4//COMMIT_MSG@10 PS4, Line 10: so that : they can be extended for specific implementations. Moreov > Yeah I think it's a good idea. I recall discussing that with you and Dan in Sounds good, will update. http://gerrit.cloudera.org:8080/#/c/8144/6/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: http://gerrit.cloudera.org:8080/#/c/8144/6/src/kudu/fs/block_manager.h@286 PS6, Line 286: > This isn't present in BlockDeletionTransaction and, AFAICT, is only used in Done. But I removed certain test code, because I don't see a clean way to access created_blocks from the cfile_test. Open to your suggestions? :) -- To view, visit http://gerrit.cloudera.org:8080/8144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60c7d437061f98ad27b9aecda5fa89e909fb2ec6 Gerrit-Change-Number: 8144 Gerrit-PatchSet: 8 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 06 Oct 2017 07:00:17 +0000 Gerrit-HasComments: Yes
