David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 )
Change subject: KUDU-1704: add READ_OWN_WRITES scan mode ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8804/1/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/8804/1/src/kudu/common/common.proto@228 PS1, Line 228: Boundedly stale reads are not repeatable: two stale reads, even if they : // use the same staleness bound, can execute at different timestamps and thus : // return inconsistent results. However, it allows read-your-writes for each : // client, as the picked timestamp must be higher than the one of the last : // write or read, known from the propagated timestamp. > Right, but I think the point is each read the server may pick different tim We talked offline a bit about this and the problem is mostly one of nomenclature. On the one side Spanner originally did make the distinction between this mode (bounded staleness read) and repeatable reads, but spanner makes the client choose a timestamp and even hints that the client should choose one in the recent past. In addition to this we also have READ_AT_SNAPSHOT without a timestamp, that we also call repeatable read (and that would be a repeatable read with a dynamic timestamp, like this one). So either we also call this repeatable read or we stop calling the other one so, maybe even change the name (to READ_CONSISTENT or whatever). Wdyt? -- To view, visit http://gerrit.cloudera.org:8080/8804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48 Gerrit-Change-Number: 8804 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 15 Dec 2017 00:26:26 +0000 Gerrit-HasComments: Yes
