Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 )
Change subject: KUDU-1704: add READ_OWN_WRITES scan mode ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8804/1/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/8804/1/src/kudu/common/common.proto@228 PS1, Line 228: transactions before it are committed. : // : // Reads in this mode are not repeatable: two stale reads, even if they : // provide the same propagated timestamp bound, can execute at different : // timestamps and thus return inconsistent results. Ho > We talked offline a bit about this and the problem is mostly one of nomencl I would lean to the second option, that stop calling READ_AT_SNAPSHOT without a timestamp repeatable reads. Rename it to READ_CONSISTENT looks good to me but we may also need to concern about backward compatibility. My main concern of calling it repeatable read is the users may get confused when the same bound is given, different results are returned (because different timestamp is chosen). -- To view, visit http://gerrit.cloudera.org:8080/8804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48 Gerrit-Change-Number: 8804 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 15 Dec 2017 01:11:55 +0000 Gerrit-HasComments: Yes
