Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 )
Change subject: [WIP] KUDU-1704: add READ_YOUR_WRITES scan mode ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8804/1/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/8804/1/src/kudu/common/common.proto@228 PS1, Line 228: transactions). If no propagated timestamp is provided the server will take : // the timestamp which all transactions before it are committed. : // : // READ_YOUR_WRITES is repeatable, i.e. all future reads at the same timestamp : // will yield the same rows. It also allows read-your- > Yes, will do, thanks! After more offline discussions and doing more research on the definition of RR (The expected behavior is that effects of a committed transaction cannot become visible in the middle of execution of a transaction), I think in the context of single row write transaction, READ_AT_SNAPSHOT without a timestamp is repeatable as well. Therefore, I think the above patch is no longer needed. -- To view, visit http://gerrit.cloudera.org:8080/8804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48 Gerrit-Change-Number: 8804 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Fri, 12 Jan 2018 03:54:35 +0000 Gerrit-HasComments: Yes