Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 )
Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode ...................................................................... Patch Set 7: (6 comments) Just a few nits on docs, but otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/8804/7/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/8804/7/src/kudu/common/common.proto@227 PS7, Line 227: n in http://gerrit.cloudera.org:8080/#/c/8804/7/src/kudu/common/common.proto@227 PS7, Line 227: any might be more clear to replace 'any' with 'some' here. http://gerrit.cloudera.org:8080/#/c/8804/7/src/kudu/common/common.proto@231 PS7, Line 231: READ_YOUR_WRITES is repeatable, i.e. all future reads at the same timestamp : // will yield the same rows I think it's worth going into a little more detail - READ_YOUR_WRITES is by itself not repeatable, but a READ_YOUR_WRITES followed by a READ_AT_SNAPSHOT with the same timestamp chosen is repeatable. http://gerrit.cloudera.org:8080/#/c/8804/7/src/kudu/common/common.proto@233 PS7, Line 233: picked s/picked/chosen http://gerrit.cloudera.org:8080/#/c/8804/7/src/kudu/tserver/tablet_service.h File src/kudu/tserver/tablet_service.h: http://gerrit.cloudera.org:8080/#/c/8804/7/src/kudu/tserver/tablet_service.h@154 PS7, Line 154: too far in the future that : // exceeds 'not so far in the future that it exceeds' http://gerrit.cloudera.org:8080/#/c/8804/7/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/8804/7/src/kudu/tserver/tablet_service.cc@1625 PS7, Line 1625: ' not your fault, but this looks like an extraneous quote. -- To view, visit http://gerrit.cloudera.org:8080/8804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48 Gerrit-Change-Number: 8804 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 01 Feb 2018 19:41:45 +0000 Gerrit-HasComments: Yes
