Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9076 )
Change subject: KUDU-2265 CA-signed server certs for non-leader masters ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/master/catalog_manager.cc@539 PS4, Line 539: } else if (catalog_manager_->NeedToPrepareFollower() && l.owns_lock()) { > I'm not a huge fan of this poll-based approach to figuring out whether we n Frankly, I don't like this piece, neither. But there is another alternative here that works fine if the CA record is already in the system table, but does not cover one corner case. The corner case is the very first start of the multi-master cluster when the CA record hasn't yet generated. And the alternative is to perform this CA-related hustle upon switching into the follower role. Actually, that's the way I started this patch, but then I realized that corner case would not be covered. Maybe, we can use the former approach but some get the edge-case covered as well? Any ideas? -- To view, visit http://gerrit.cloudera.org:8080/9076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3539d58d10ed319ad1d8686c1259c92822fb710 Gerrit-Change-Number: 9076 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 19 Jan 2018 23:04:06 +0000 Gerrit-HasComments: Yes
