Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9076 )
Change subject: KUDU-2265 CA-signed server certs for non-leader masters ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/master/catalog_manager.cc@539 PS4, Line 539: } else if (catalog_manager_->NeedToPrepareFollower() && l.owns_lock()) { > Frankly, I don't like this piece, neither. FWIW Adar and I discussed this offline last week, and my opinion is that long-term I'd prefer what Adar's suggesting, but I don't think this limited-scope change warrants such an overhaul/refactor. http://gerrit.cloudera.org:8080/#/c/9076/1/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: http://gerrit.cloudera.org:8080/#/c/9076/1/src/kudu/security/tls_context.cc@405 PS1, Line 405: RETURN_NOT_OK(VerifyCertChainUnlocked(cert)); > This particular change is not related to KUDU-2265. I just noticed that it Ah ok, I think that's fine. I was just curious if this had any effect besides the optimization. -- To view, visit http://gerrit.cloudera.org:8080/9076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3539d58d10ed319ad1d8686c1259c92822fb710 Gerrit-Change-Number: 9076 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 23 Jan 2018 19:49:40 +0000 Gerrit-HasComments: Yes
