Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9076 )
Change subject: KUDU-2265 CA-signed server certs for non-leader masters ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.h@415 PS6, Line 415: acquiring the catalog manager's leader_lock_ : // for reading in the process. T This seems to not quite be correct. In fact it just tries to acquire the leader_lock but doesn't necessarily succeed. We should update this documentation to be clear that after constructing this, you need to call one of the two Check* methods http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.h@444 PS6, Line 444: bool owns_lock() const { (see note above about the docs on the constructor -- I was quite confused initially seeing this when the ctor docs say it unconditionally acquires a lock) http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.cc@a791 PS6, Line 791: Can we AssertAcquiredForReading in the new impl? http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.cc@a814 PS6, Line 814: same http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.cc@997 PS6, Line 997: LOG(INFO) << LogPrefix can we use LOG_WITH_PREFIX() here? -- To view, visit http://gerrit.cloudera.org:8080/9076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3539d58d10ed319ad1d8686c1259c92822fb710 Gerrit-Change-Number: 9076 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 23 Jan 2018 22:48:29 +0000 Gerrit-HasComments: Yes
