Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9076 )
Change subject: KUDU-2265 CA-signed server certs for non-leader masters ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.h@415 PS6, Line 415: acquiring the catalog manager's leader_lock_ : // for reading in the process. T > This seems to not quite be correct. In fact it just tries to acquire the le Good catch, done. http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.h@444 PS6, Line 444: bool owns_lock() const { > (see note above about the docs on the constructor -- I was quite confused i Done http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/master/catalog_manager.cc@539 PS4, Line 539: } else if (catalog_manager_->NeedToPrepareFollower() && l.owns_lock()) { > FWIW Adar and I discussed this offline last week, and my opinion is that lo OK, thanks for the clarification -- I totally agree that this poll-based approach is not the best what we can do here. Let it be just simple polling for a while, and later we can replace it with nice and shiny subscription/notification approach. http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.cc@a791 PS6, Line 791: > Can we AssertAcquiredForReading in the new impl? In the new impl, this method can be called holding either with reading or writing lock. I remember some time ago there was an attempt to have AssertAcquiredForReadingOrWriting(), but then consensus was that it's not worth it. Let's see how it goes this time :) http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.cc@a814 PS6, Line 814: > same yup http://gerrit.cloudera.org:8080/#/c/9076/6/src/kudu/master/catalog_manager.cc@997 PS6, Line 997: LOG(INFO) << LogPrefix > can we use LOG_WITH_PREFIX() here? Done -- To view, visit http://gerrit.cloudera.org:8080/9076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3539d58d10ed319ad1d8686c1259c92822fb710 Gerrit-Change-Number: 9076 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 24 Jan 2018 08:02:17 +0000 Gerrit-HasComments: Yes
