Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9076 )
Change subject: KUDU-2265 CA-signed server certs for non-leader masters ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/integration-tests/CMakeLists.txt File src/kudu/integration-tests/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/integration-tests/CMakeLists.txt@98 PS4, Line 98: ADD_KUDU_TEST(security-master-certificates-itest RESOURCE_LOCK "master-rpc-ports") > Nit: retain alphabetical sorting. Done http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/integration-tests/security-master-certificates-itest.cc File src/kudu/integration-tests/security-master-certificates-itest.cc: http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/integration-tests/security-master-certificates-itest.cc@49 PS4, Line 49: class SecurityMasterCertsTest : public KuduTest { > Is there a fixture you could inherit from that would set up the cluster for I didn't find anything lightweight enough -- there are test other fixtures using InternalMiniCluster, but they include much more custom stuff. http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/integration-tests/security-master-certificates-itest.cc@51 PS4, Line 51: SecurityMasterCertsTest() { : } > Can omit? Done http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/master/catalog_manager.h@668 PS4, Line 668: bool NeedToPrepareFollower(); > Doc? Done http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/mini-cluster/internal_mini_cluster.h File src/kudu/mini-cluster/internal_mini_cluster.h: http://gerrit.cloudera.org:8080/#/c/9076/4/src/kudu/mini-cluster/internal_mini_cluster.h@80 PS4, Line 80: // Whether to wait while catalog manager is started and properly initialized > Nit: specify the default value here. It turned out this newly introduced field is not needed. -- To view, visit http://gerrit.cloudera.org:8080/9076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3539d58d10ed319ad1d8686c1259c92822fb710 Gerrit-Change-Number: 9076 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sat, 20 Jan 2018 00:21:47 +0000 Gerrit-HasComments: Yes
