Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 )
Change subject: KUDU-2412: Fix python client compilation in el6 environments ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10114/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10114/1//COMMIT_MSG@16 PS1, Line 16: stament Nit: statement http://gerrit.cloudera.org:8080/#/c/10114/1//COMMIT_MSG@15 PS1, Line 15: The preprocessor statements : do not work inside of a cdef stament This doesn't seem right though because in your patch you ARE using conditional statements inside "cdef class foo" style cdef statements. So is the restriction about using them within "cdef foo(int a, double b)" style statements? I don't see anything in the docs to suggest that this is the case. -- To view, visit http://gerrit.cloudera.org:8080/10114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7 Gerrit-Change-Number: 10114 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 19 Apr 2018 18:10:48 +0000 Gerrit-HasComments: Yes
