Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 )
Change subject: KUDU-2412: Fix python client compilation in el6 environments ...................................................................... Patch Set 2: (1 comment) Grant, you want to finish this up or shall I? http://gerrit.cloudera.org:8080/#/c/10114/2/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/10114/2/python/setup.py@90 PS2, Line 90: subprocess.check_call(["cc", "-x", "c++", "-o", dst, > Why "cc -x c++" and not "c++"? Thing is we probably want to honor the CC/CX because of the funny extension we have to use -x -- otherwise it doesn't know it's a source file and thinks it's a library or something. Agreed though we should use CXX. At first I attempted to use distutils.ccompiler but it was pretty finicky. -- To view, visit http://gerrit.cloudera.org:8080/10114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7 Gerrit-Change-Number: 10114 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 19 Apr 2018 19:04:31 +0000 Gerrit-HasComments: Yes
