Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 )
Change subject: KUDU-2412: Fix python client compilation in el6 environments ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/10114/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10114/3//COMMIT_MSG@9 PS3, Line 9: This uses the C preprocessor to check the value of KUDU_INT128_SUPPORTED Should probably add the bit about config.pxi and how it works. http://gerrit.cloudera.org:8080/#/c/10114/3/python/kudu/config.pxi.in File python/kudu/config.pxi.in: http://gerrit.cloudera.org:8080/#/c/10114/3/python/kudu/config.pxi.in@18 PS3, Line 18: // This file is processed by setup.py using the C preprocessor : // after defining the macros from kudu/util/int128.h. Nit: config.pxi is intended to be semi-generic going forward, so perhaps this definition should be more abstract? http://gerrit.cloudera.org:8080/#/c/10114/3/python/kudu/libkudu_client.pxd File python/kudu/libkudu_client.pxd: http://gerrit.cloudera.org:8080/#/c/10114/3/python/kudu/libkudu_client.pxd@20 PS3, Line 20: include "config.pxi" Not needed anymore? Or just for consistency? http://gerrit.cloudera.org:8080/#/c/10114/2/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/10114/2/python/setup.py@90 PS2, Line 90: dst_tmp = dst + '.tmp' Why "cc -x c++" and not "c++"? Thing is we probably want to honor the CC/CXX environment variables, but since we're compiling C++ it's probably better to just consider CXX. -- To view, visit http://gerrit.cloudera.org:8080/10114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7 Gerrit-Change-Number: 10114 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 19 Apr 2018 19:00:31 +0000 Gerrit-HasComments: Yes
