Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 )
Change subject: KUDU-2412: Fix python client compilation in el6 environments ...................................................................... Patch Set 3: tweaked this a bit: - seems that it's fine to list the int128 methods in the .pxd files even if int128 isn't supported. The pxds don't generate their own definitions in the generated C code, they just expose metadata about what might be there, so it doesn't produce syntax errors. - switched to using the C preprocessor to generate config.pxi.in based on the version checking logic in the client header, to avoid duplicating logic -- To view, visit http://gerrit.cloudera.org:8080/10114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7 Gerrit-Change-Number: 10114 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 19 Apr 2018 18:59:14 +0000 Gerrit-HasComments: No
