Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10114 )
Change subject: KUDU-2412: Fix python client compilation in el6 environments ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10114/1/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/10114/1/python/kudu/client.pyx@1332 PS1, Line 1332: IF KUDU_INT128_SUPPORTED == 1: > Hmm, so what happens if you reformat this like so: I did this too as I played with it http://gerrit.cloudera.org:8080/#/c/10114/1/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/10114/1/python/setup.py@76 PS1, Line 76: # Identify the cc version used and check for __int128 support > How about using a compile test instead? Then you won't have to worry about I ended up doing something akin to this in r3 -- To view, visit http://gerrit.cloudera.org:8080/10114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7 Gerrit-Change-Number: 10114 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 19 Apr 2018 19:01:45 +0000 Gerrit-HasComments: Yes
