Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10342 )
Change subject: [flags] run validators after processing help flags ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10342/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10342/1//COMMIT_MSG@20 PS1, Line 20: linker optimizes the matter : and removes the validators if linking statically > Right: I also looked at the possibility to just provide the validator funct kserver was not so good idea -- tserver depends on it, and eventually the kudu CLI tool is dependent on that as well via kudu_mini_cluster. I think there are two options here: do a lot of surgery in splitting the libraries so mini_cluster would not depend on kserver, or just put the validators in to another library and call a function from that library in both tserver and master. -- To view, visit http://gerrit.cloudera.org:8080/10342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51f263890c91251f0d13c826c40dfd20fe284b59 Gerrit-Change-Number: 10342 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 08 May 2018 20:26:05 +0000 Gerrit-HasComments: Yes
