Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10342 )
Change subject: [flags] run validators after processing help flags ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10342/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10342/1//COMMIT_MSG@25 PS1, Line 25: Another (rather hacky) way of dealing with the issue would be : adding FLAGS_force_block_cache_capacity=true into the : src/kudu/tool/tool_main.cc file. What if we inverted this? Meaning, what if force_block_cache_capacity defaulted to false, and was explicitly overridden to true in the master/tserver? That won't be nearly as hacky because we have precedent of changing flags' default values for the servers. Plus it'll let us revert some force_block_cache_capacity=false instances in unit tests. -- To view, visit http://gerrit.cloudera.org:8080/10342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51f263890c91251f0d13c826c40dfd20fe284b59 Gerrit-Change-Number: 10342 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 08 May 2018 21:54:30 +0000 Gerrit-HasComments: Yes
