Hello Will Berkeley, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10342
to look at the new patch set (#5).
Change subject: [flags] run validators after processing help flags
......................................................................
[flags] run validators after processing help flags
Run flag validators (both individual and group ones) after
processing the help flags.
Also, this is a follow-up for 297b72bd26cdd546f0a73cda7487c80566388492:
the group validator for the --block_cache_capacity_mb and
--memory_limit_hard_bytes flags is moved into the separate library
tserver_flag_validators which is linked by appropriate Kudu servers
(i.e. kudu-master and kudu-tserver). Otherwise, its presence in other
libraries used by the kudu CLI tool causes the tool to output
validation errors and exiting with an error when running at machines
with less than 256 MB of available memory.
Change-Id: I51f263890c91251f0d13c826c40dfd20fe284b59
---
M src/kudu/cfile/block_cache.cc
M src/kudu/consensus/CMakeLists.txt
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/master/CMakeLists.txt
M src/kudu/master/master_main.cc
M src/kudu/tools/CMakeLists.txt
M src/kudu/tserver/CMakeLists.txt
M src/kudu/tserver/tablet_server.cc
A src/kudu/tserver/tablet_server_flag_validators.cc
M src/kudu/tserver/tablet_server_main.cc
M src/kudu/util/flags.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
13 files changed, 121 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/10342/5
--
To view, visit http://gerrit.cloudera.org:8080/10342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51f263890c91251f0d13c826c40dfd20fe284b59
Gerrit-Change-Number: 10342
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
