Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10342
Change subject: [flags] run validators after processing help flags ...................................................................... [flags] run validators after processing help flags Run flag validators (both individual and group ones) after processing the help flags. Also, this is a follow-up for 297b72bd26cdd546f0a73cda7487c80566388492: the group validator for the --block_cache_capacity_mb and --memory_limit_hard_bytes flags is moved into the tserver binary itself. Otherwise, its presence in the tserver library caused the kudu CLI binary to output the validation error and exiting when running at machines with less than 256 MB of available memory. I tried to separate the validators and link them as a library both into the tserver and master, but the linker optimizes the matter and removes the validators if linking statically (release builds). I think keeping the validator just in the kudu-tserver binary should be enough. Another (rather hacky) way of dealing with the issue would be adding FLAGS_force_block_cache_capacity=true into the src/kudu/tool/tool_main.cc file. Change-Id: I51f263890c91251f0d13c826c40dfd20fe284b59 --- M src/kudu/cfile/block_cache.cc M src/kudu/consensus/CMakeLists.txt M src/kudu/integration-tests/CMakeLists.txt M src/kudu/master/CMakeLists.txt M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/tablet_server.cc A src/kudu/tserver/tablet_server_flag_validators.cc M src/kudu/util/flags.cc M src/kudu/util/metrics.cc M src/kudu/util/metrics.h 10 files changed, 89 insertions(+), 57 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/10342/1 -- To view, visit http://gerrit.cloudera.org:8080/10342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I51f263890c91251f0d13c826c40dfd20fe284b59 Gerrit-Change-Number: 10342 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]>
