Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10342 )
Change subject: [flags] run validators after processing help flags ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10342/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10342/1//COMMIT_MSG@25 PS1, Line 25: Another (rather hacky) way of dealing with the issue would be : adding FLAGS_force_block_cache_capacity=true into the : src/kudu/tool/tool_main.cc file. > What if we inverted this? Meaning, what if force_block_cache_capacity defau Yep, it would be an option as well. Not sure it would allow to revert setting force_block_cache_capacity=true in many tests, since as of now it's set only for a couple of tests that use ExternalMiniCluster. >From the other side, removing unnecessary group validators from looks like a >noble goal as well :) Another idea we discussed today with Mike and Will was to introduce applicable modules for flags and corresponding validators, so those would not even register if not in appropriate module. That way it would be possible to get rid of multiple unnecessary 'hidden' flags in the kudu CLI binary. However, that path requires more changes. -- To view, visit http://gerrit.cloudera.org:8080/10342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51f263890c91251f0d13c826c40dfd20fe284b59 Gerrit-Change-Number: 10342 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 09 May 2018 00:51:54 +0000 Gerrit-HasComments: Yes
